Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

optimize: trimmer match method go name #199

Merged
merged 1 commit into from
Apr 29, 2024

Conversation

HeyJavaBean
Copy link
Member

@HeyJavaBean HeyJavaBean commented Apr 29, 2024

Description

trimmer 的配置文件里,Method 默认是 IDL 的名称,会通过传入的名称与 IDL 里的进行对比
但有的场景,Method 写的是 Golang 风格的名称,这里提供一个额外的参数 MatchGoName,用来将 IDL 里的 Method 转化为 Golang 风格,以此完成匹配

Motivation and Context

Related Issue

@HeyJavaBean HeyJavaBean requested review from a team as code owners April 29, 2024 09:53
@HeyJavaBean HeyJavaBean enabled auto-merge (squash) April 29, 2024 09:55
@HeyJavaBean HeyJavaBean merged commit b4b1e45 into cloudwego:main Apr 29, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants