Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

支持使用自定义 Codec 实现 #79

Closed
PureWhiteWu opened this issue Nov 2, 2022 · 1 comment · Fixed by #92
Closed

支持使用自定义 Codec 实现 #79

PureWhiteWu opened this issue Nov 2, 2022 · 1 comment · Fixed by #92
Assignees
@PureWhiteWu
Labels
A-volo-thrift The issue concerns the `volo-thrift` crate. C-proposal A proposal of some kind, and a request for comments.

Comments

@PureWhiteWu
Copy link
Member

Feature Request

Crates

volo-thrift

Motivation

目前我们仅支持了 CodecType 的设置，但是 Codec 的实现仍然是写死的 BinaryProtocol，并且不允许替换实现。

为了支持更多的 Protocol 和使用场景，也为了之后的 Codec 性能优化做准备，我们需要支持自定义 Codec 实现。

Proposal

TBD
@PureWhiteWu PureWhiteWu added A-volo-thrift The issue concerns the `volo-thrift` crate. C-proposal A proposal of some kind, and a request for comments. labels Nov 2, 2022
@PureWhiteWu PureWhiteWu self-assigned this Nov 2, 2022
@PureWhiteWu
Copy link
Member Author

fixed in #92

@PureWhiteWu PureWhiteWu linked a pull request Nov 22, 2022 that will close this issue
feat: support zerocopy codec #92
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@PureWhiteWu PureWhiteWu

Labels
A-volo-thrift The issue concerns the `volo-thrift` crate. C-proposal A proposal of some kind, and a request for comments.
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: support zerocopy codec PureWhiteWu/volo
1 participant
@PureWhiteWu