feat: introduce volo-http crate
#264
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Maybe the |
PureWhiteWu
previously approved these changes
Nov 24, 2023
Millione
reviewed
Nov 27, 2023
wfly1998
force-pushed
the
feat/volo-http
branch
from
c8e475e
to
b82673d
Compare
Signed-off-by: Gwo Tzu-Hsing <gotzehsing@gmail.com> Signed-off-by: Zheng Li <875543533@qq.com> Signed-off-by: bobozhengsir <bobozhengsir@gmail.com> Signed-off-by: Yu Li <liyu.yukiteru@bytedance.com>
Signed-off-by: Gwo Tzu-Hsing <gotzehsing@gmail.com> Signed-off-by: Zheng Li <875543533@qq.com> Signed-off-by: bobozhengsir <bobozhengsir@gmail.com> Signed-off-by: Yu Li <liyu.yukiteru@bytedance.com>
The `matchit::Router` cannot be converted to `Iterator`, so using `matchit::Router<DynService>` is not convenient enough. To solve the problem, we refer to the implementation of `axum` and introduce a `RouteId` as a bridge, the `matchit::Router` only handles some IDs and each ID corresponds to a `DynService`. Signed-off-by: Yu Li <liyu.yukiteru@bytedance.com>
With tie type `Route`, it can support `Service`, `Handler` and so on. Signed-off-by: Yu Li <liyu.yukiteru@bytedance.com>
With this commit, there is no need to keep `HttpContext` in handler function. Like axum, anything with `FromContext` or `FromRequest` trait can be used as arguments of a handler. Signed-off-by: Yu Li <liyu.yukiteru@bytedance.com>
Note that `hyper` v1.0.0-rc4 replaces IO traits from `tokio` with its IO traits in `hyper::rt`. To solve the building problem, we can introduce `TokioIo` from `hyper-util` and wrap the `DefaultIncoming` by the `TokioIo`. Also, the `volo-grpc` uses `hyper` v0.14 with its auto-version (using both http1 and http2) and graceful shutdown, but the latest `hyper` and `hyper-util` cannot use the both features at the same time, so the version of `hyper` in `volo` has not been upgraded. Ref: - hyperium/hyper@f9f65b7 - hyperium/hyper#3013 - hyperium/hyper#2862 Signed-off-by: Yu Li <liyu.yukiteru@bytedance.com>
质疑 axum，理解 axum，成为 axum Signed-off-by: Yu Li <liyu.yukiteru@bytedance.com>
With the previous codes, server could not stop immediately after pressing Ctrl+C, but waited until timeout before exiting. This commit uses the same approach as "volo-thrift" and the problem has been resolved. Signed-off-by: Yu Li <liyu.yukiteru@bytedance.com>
This commit supports fallback in `Router` and `MethodRouter`. With `fallback`, when no route or method can handle the request, the `fallback` will be called and the specified response will be returned. Signed-off-by: Yu Li <liyu.yukiteru@bytedance.com>
This commit adds a `TimeoutLayer` for `volo-http` which can use a function as a callback and when timeout occurs, it will return a response by the callback. Signed-off-by: Yu Li <liyu.yukiteru@bytedance.com>
Signed-off-by: Yu Li <liyu.yukiteru@bytedance.com>
Signed-off-by: Yu Li <liyu.yukiteru@bytedance.com>
wfly1998
force-pushed
the
feat/volo-http
branch
from
b82673d
to
8ec89d8
Compare
Millione
approved these changes
Nov 27, 2023
PureWhiteWu
approved these changes
Nov 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To support HTTP protocol, we introduce a crate
volo-http, which is greatly inspired byaxum.An example is provided in
examples/src/http/simple.rs.