chore(volo-http): refactor config of context #387
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
The previous context has an argument
stat_enable
in itsnew
function, but it can be set in other ways and setting it innew
is not a good design. However,tls
, in other words, whether tls is enabled should not be changed during processing request, so it is better to set it inClientContext::new
.In addition, in previous codes, we should import
volo::context::Context
for gettingtls
andstat_enable
, and it is not a good design, too. It requires a getter or setter function.Solution
ServerContext::new(target: Address, stat_enable: bool)
->ServerContext::new(target: Address)
ClientContext::new(target: Address, stat_enable: bool)
->ClientContext::new(target: Address, tls: bool)
xxxContext::enable_stat
,xxxContext::stat_enabled
andClientCxInner::tls