Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(volo-http): add handler for timeout layer #420

Merged
merged 2 commits into from
Apr 17, 2024
Merged

feat(volo-http): add handler for timeout layer #420

merged 2 commits into from
Apr 17, 2024

Conversation

yukiiiteru
Copy link
Member

Motivation

When refactoring ServerContext, we removed handler for TimeoutLayer (with FromContext), but handler is important for the layer.

Solution

Add a simple handler for TimeoutLayer. The handler accepts only FnOnce(&ServerContext) -> impl IntoResponse + Clone rather than Handler with FromContext.

@yukiiiteru
feat(volo-http): add handler for timeout layer
a3fa385 
Signed-off-by: Yu Li <liyu.yukiteru@bytedance.com>
@yukiiiteru
chore(volo-http): bump volo-http to 0.2.1
2b95a3b 
Signed-off-by: Yu Li <liyu.yukiteru@bytedance.com>
@yukiiiteru yukiiiteru requested review from a team as code owners April 17, 2024 07:10
@yukiiiteru yukiiiteru merged commit 61b1a9b into cloudwego:main Apr 17, 2024
7 of 14 checks passed
@yukiiiteru yukiiiteru deleted the feat/http-timeout-handler branch April 17, 2024 07:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PureWhiteWu PureWhiteWu PureWhiteWu approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@yukiiiteru @PureWhiteWu