Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix dockerfile #39

Merged
merged 2 commits into from
May 22, 2023
Merged

Fix dockerfile #39

merged 2 commits into from
May 22, 2023

Conversation

lmunch
Copy link
Contributor

@lmunch lmunch commented May 19, 2023

I believe this fixes #38

@lmunch
Fix indentation and white space
9c3ddd7
@lmunch
Fix container image not finding image-create.sh
a00b71c 
This fix moves the image-create.sh back to /app and instead
uses the PWD history to back to working directory.

Using SCRIPTDIR breaks the posibility of putting
image-create.sh in /usr/bin
@lmunch lmunch mentioned this pull request May 19, 2023
Closed
@cloudymax
Copy link
Owner

Thanks, testing this now!

cloudymax
cloudymax approved these changes May 22, 2023
View reviewed changes
Copy link
Owner

@cloudymax cloudymax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, tested with and without docker for basic, extra-files, and offline install 🥳

@cloudymax cloudymax merged commit e5ee5bd into cloudymax:develop May 22, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cloudymax cloudymax cloudymax approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

stat /data/image-create.sh: no such file or directory: unknown.
2 participants
@lmunch @cloudymax