Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix example project node semantic version issue #11

Merged
merged 5 commits into from Jun 5, 2019
Merged

Fix example project node semantic version issue #11

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
3a1ed61
Explicitly indicate gulp version, commit package-lock for reproducibl…
zakpatterson Jun 2, 2019
8f9d0dd
Add note in readme about nodejs version
zakpatterson Jun 2, 2019
50b9b0f
Upgrade outwatch commit version
zakpatterson Jun 2, 2019
c59dc30
Upgrade scalajs
zakpatterson Jun 2, 2019
e6960f1
Update travis image
zakpatterson Jun 5, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
1 change: 0 additions & 1 deletion .gitignore
View file
Open in desktop
Expand Up @@ -149,6 +149,5 @@ GitHub.sublime-settings
examples/assets/semantic/
examples/semantic/
yarn.lock
package-lock.json
node_modules
/todomvc/assets/todomvc/main.css
6 changes: 3 additions & 3 deletions .travis.yml
View file
Open in desktop
@@ -1,5 +1,5 @@
language: scala

dist: xenial
before_install:
- export PATH=${PATH}:./vendor/bundle

Expand All @@ -13,7 +13,7 @@ install:

scala:
- 2.12.8

jobs:
include:
- stage: verify
Expand All @@ -38,4 +38,4 @@ deploy:
local-dir: ex-docs/site
target-branch: gh-pages
on:
branch: master
branch: master
2 changes: 2 additions & 0 deletions README.md
View file
Open in desktop
Expand Up @@ -5,6 +5,8 @@ Prerequisites
---
Examples in this project use scalajs-bundler, which requires npm, yarn, and webpack working locally.

Due to [this issue](https://github.com/Semantic-Org/Semantic-UI/issues/6818) in semantic-ui, you must be running a Nodejs v10.

TodoMVC and a simple Login/Register authentication form is implemented. Needs some improvement. [You can view the documentation and examples here](https://clovellytech.github.io/outwatch-examples/).

TodoMVC
Expand Down
8 changes: 4 additions & 4 deletions build.sbt
View file
Open in desktop
Expand Up @@ -18,8 +18,8 @@ val depSettings = Seq(
libraryDependencies ++= Seq(
"io.github.outwatch" % "outwatch" % versions.outwatch,
"org.scalatest" %%% "scalatest" % versions.scalaTest % Test,
"com.clovellytech" %%% "outwatch-router" % "0.0.5",
"org.scala-js" %%% "scalajs-dom" % "0.9.6",
"com.clovellytech" %%% "outwatch-router" % "0.0.6",
"org.scala-js" %%% "scalajs-dom" % "0.9.7",
) ++ Seq(
"circe-core",
"circe-generic",
Expand All @@ -34,8 +34,8 @@ val scalaJsSettings = Seq(
jsEnv in Test := new org.scalajs.jsenv.jsdomnodejs.JSDOMNodeJSEnv,
scalaJSUseMainModuleInitializer := true,
scalaJSModuleKind := ModuleKind.CommonJSModule, // configure Scala.js to emit a JavaScript module instead of a top-level script
version in webpack := "4.16.1",
version in startWebpackDevServer := "3.1.4",
version in webpack := "4.32.2",
version in startWebpackDevServer := "3.5.1",
webpackDevServerExtraArgs := Seq("--progress", "--color"),
webpackConfigFile in fastOptJS := Some(baseDirectory.value / "webpack.config.dev.js"),
// https://scalacenter.github.io/scalajs-bundler/cookbook.html#performance
Expand Down