$app['beforeTokenChecker'] のモジュール化 & ユニットテスト #19
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
fast-forward できなくなってたので git pull --rebase して送り直したらなんかテスト壊れちゃいましたね... |
|
|
cloverstudio
pushed a commit
that referenced
this pull request
Oct 20, 2013
$app['beforeTokenChecker'] のモジュール化 & ユニットテスト
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
無名関数として実装されていた
$app['beforeTokenChecker']をクラス化し、ユニットテストを書いています。./srcディレクトリに移しているので、コードカバレッジの計測対象にも含まれるようになっています。その他の特記事項は以下の通りです。
TokenValidTimeをTOKEN_VALID_TIMEに変更 (コーディング規約への対応)DbInterfaceにfindUserById()メソッドを追加TokenCheckerが返すレスポンスについて、エラーメッセージが違うのではないかと思うもの (ユーザがデータベース上に見つからなかったとき) もありましたが、とりあえずはそのままにしています。