throw exit code after printing test output

clowd · Dec 26, 2023 · 4c7eacb · 4c7eacb
1 parent f12aa46
commit 4c7eacb
Showing 1 changed file with 4 additions and 3 deletions.
diff --git a/test/Squirrel.Packaging.Tests/WindowsPackTests.cs b/test/Squirrel.Packaging.Tests/WindowsPackTests.cs
@@ -405,9 +405,6 @@ private string RunImpl(ProcessStartInfo psi, ILogger logger, int? exitCode = 0)
 
             logger.Info($"TEST: Process exited with code {p.ExitCode} in {elapsed.TotalSeconds}s");
 
-            if (exitCode != null)
-                Assert.Equal(exitCode, p.ExitCode);
-
             using var fs = Utility.Retry(() => {
                 return File.Open(outputfile, FileMode.Open, FileAccess.ReadWrite, FileShare.None);
             }, 10, 1000, logger);
@@ -421,6 +418,10 @@ private string RunImpl(ProcessStartInfo psi, ILogger logger, int? exitCode = 0)
                 logger.Info($"TEST: Process output: {Environment.NewLine}{output.Trim()}{Environment.NewLine}");
             }
 
+            if (exitCode.HasValue && p.ExitCode != exitCode.Value) {
+                throw new Exception($"Process exited with code {p.ExitCode} but expected {exitCode.Value}");
+            }
+
             return String.Join(Environment.NewLine,
                 output
                     .Split('\n')