Skip to content

Commit

Permalink
Merge pull request #314 from clowder-framework/log4j
Browse files Browse the repository at this point in the history
Log4j
  • Loading branch information
robkooper committed Jan 24, 2022
2 parents 834ca94 + 107d9fa commit 17651a4
Show file tree
Hide file tree
Showing 17 changed files with 665 additions and 135 deletions.
20 changes: 15 additions & 5 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,7 @@ jobs:
echo "CLOWDER_VERSION=$(awk '/version = / { print $4 }' project/Build.scala | sed 's/"//g')" >> $GITHUB_ENV
elif [ "$BRANCH" == "develop" ]; then
echo "CLOWDER_VERSION=develop" >> $GITHUB_ENV
else
else
echo "CLOWDER_VERSION=testing" >> $GITHUB_ENV
fi
- uses: actions/setup-java@v1
Expand Down Expand Up @@ -97,7 +97,7 @@ jobs:
echo "CLOWDER_VERSION=$(awk '/version = / { print $4 }' project/Build.scala | sed 's/"//g')" >> $GITHUB_ENV
elif [ "$BRANCH" == "develop" ]; then
echo "CLOWDER_VERSION=develop" >> $GITHUB_ENV
else
else
echo "CLOWDER_VERSION=testing" >> $GITHUB_ENV
fi
- uses: actions/setup-java@v1
Expand Down Expand Up @@ -141,7 +141,7 @@ jobs:
echo "CLOWDER_VERSION=$(awk '/version = / { print $4 }' project/Build.scala | sed 's/"//g')" >> $GITHUB_ENV
elif [ "$BRANCH" == "develop" ]; then
echo "CLOWDER_VERSION=develop" >> $GITHUB_ENV
else
else
echo "CLOWDER_VERSION=testing" >> $GITHUB_ENV
fi
- uses: actions/setup-java@v1
Expand All @@ -164,6 +164,16 @@ jobs:
VERSION: ${{ env.CLOWDER_VERSION }}
BUILDNUMBER: ${{ github.run_number }}
GITSHA1: ${{ github.sha }}
- name: fix log4j
run: |
ZIPFILE=$(ls -1rt target/universal/*.zip | head -1)
DIR=$(basename ${ZIPFILE} .zip)
unzip -q ${ZIPFILE}
for x in $(find ${DIR} -name \*.jar); do
zip -d $x org/apache/log4j/net/JMSAppender.class org/apache/log4j/net/SocketServer.class | grep 'deleting:' && echo "fixed $x"
done
rm ${ZIPFILE}
zip -r ${ZIPFILE} ${DIR}
- uses: actions/upload-artifact@v2
with:
name: clowder.zip
Expand Down Expand Up @@ -207,7 +217,7 @@ jobs:
echo "CLOWDER_VERSION=$(awk '/version = / { print $4 }' project/Build.scala | sed 's/"//g')" >> $GITHUB_ENV
elif [ "$BRANCH" == "develop" ]; then
echo "CLOWDER_VERSION=develop" >> $GITHUB_ENV
else
else
echo "CLOWDER_VERSION=testing" >> $GITHUB_ENV
fi
- uses: actions/setup-java@v1
Expand Down Expand Up @@ -247,7 +257,7 @@ jobs:
key: ${{ secrets.SCP_KEY }}
files: "target/scala-*/api/*"
target: "CATS/${{ env.CLOWDER_VERSION }}/documentation/scaladoc"
- name: sphinx
- name: sphinx
run: |
cd doc/src/sphinx/
python -m pip install -r requirements.txt
Expand Down
8 changes: 7 additions & 1 deletion .github/workflows/docker.yml
Original file line number Diff line number Diff line change
Expand Up @@ -36,6 +36,7 @@ jobs:
- clowder
- mongo-init
- monitor
- elasticsearch
include:
- name: clowder
FOLDER: "."
Expand All @@ -49,6 +50,11 @@ jobs:
FOLDER: scripts/monitor
IMAGE: monitor
README: ""
- name: elasticsearch
FOLDER: scripts/elasticsearch
IMAGE: elasticsearch
README: ""

steps:
- uses: actions/checkout@v2

Expand All @@ -75,7 +81,7 @@ jobs:
elif [ "$BRANCH" == "develop" ]; then
echo "CLOWDER_VERSION=develop" >> $GITHUB_ENV
echo "CLOWDER_TAGS=develop" >> $GITHUB_ENV
else
else
echo "CLOWDER_VERSION=testing" >> $GITHUB_ENV
echo "CLOWDER_TAGS=" >> $GITHUB_ENV
fi
Expand Down
6 changes: 6 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,12 @@ All notable changes to this project will be documented in this file.
The format is based on [Keep a Changelog](http://keepachangelog.com/)
and this project adheres to [Semantic Versioning](http://semver.org/).

## 1.19.5 - 2022-01-21

### Fixed
- Removed JMSAppender and SocketServer from log4j.
- Cleaned up getting started documentation.

## 1.19.4 - 2021-11-11

### Fixed
Expand Down
1 change: 1 addition & 0 deletions CONTRIBUTORS.md
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,7 @@ Following is a list of contributors in alphabetical order:
- Inna Zharnitsky
- Jim Myers
- Jong Lee
- Kastan Day
- Kaveh Karimi-Asli
- Kenton McHenry
- Luigi Marini
Expand Down
5 changes: 5 additions & 0 deletions Dockerfile
Original file line number Diff line number Diff line change
Expand Up @@ -30,6 +30,11 @@ RUN rm -rf target/universal/clowder-*.zip clowder clowder-* \
&& ./sbt dist \
&& unzip -q target/universal/clowder-*.zip \
&& mv clowder-* clowder \
&& apk add --no-cache zip \
&& for x in $(find clowder -name \*.jar); do \
zip -d $x org/apache/log4j/net/JMSAppender.class org/apache/log4j/net/SocketServer.class | grep 'deleting:' && echo "fixed $x"; \
done; \
echo "removed JMSAppender and SocketServer" \
&& mkdir -p clowder/custom clowder/logs

# ----------------------------------------------------------------------
Expand Down
Binary file added doc/src/sphinx/_static/GettingStarted_AddJDK.png
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added doc/src/sphinx/_static/IntelliJ_JDK_Download.png
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
124 changes: 0 additions & 124 deletions doc/src/sphinx/admin/installing.rst

This file was deleted.

2 changes: 1 addition & 1 deletion doc/src/sphinx/conf.py
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@
author = 'Luigi Marini'

# The full version, including alpha/beta/rc tags
release = '1.19.4'
release = '1.19.5'


# -- General configuration ---------------------------------------------------
Expand Down
2 changes: 1 addition & 1 deletion doc/src/sphinx/index.rst
Original file line number Diff line number Diff line change
Expand Up @@ -44,13 +44,13 @@ Contents
:caption: Getting Started

userguide/ug_index
userguide/installing_clowder
api

.. toctree::
:maxdepth: 1
:caption: Administration

admin/installing
admin/upgrading
admin/customizing

Expand Down

0 comments on commit 17651a4

Please sign in to comment.