Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Vega previewer tab shows even if vega definition is not in metadata #408

Open
lmarini opened this issue Apr 11, 2023 · 0 comments
Open

Vega previewer tab shows even if vega definition is not in metadata #408

lmarini opened this issue Apr 11, 2023 · 0 comments
Assignees
@lmarini
Labels
bug Something isn't working

Comments

@lmarini
Copy link
Member

lmarini commented Apr 11, 2023 •
edited

The vega.js previewer runs on files of type application/json and text/csv. If the file doesn't have a preview, no tabs are shown. But if the file has a preview, for example a png image, the vega.js previewer tab shows in the list even if the files doesn't have a vega definition with it.

Looking at the code, it should show "Invalid JSON is provided for Vega specs" on the page, but we didn't see that.
@lmarini lmarini added the bug Something isn't working label Apr 11, 2023
@lmarini lmarini self-assigned this Apr 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lmarini lmarini

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@lmarini