Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Track individual events using Amplitude #133

Merged
merged 5 commits into from Nov 20, 2020

Conversation

bodom0015
Copy link
Member

@bodom0015 bodom0015 commented Nov 11, 2020

Description

#132 adds basic required support for Amplitude tracking.

This supplemental PR adds some code to send individual tracking events:

  • view_resource: Tracks File/Dataset/Collection Views (includes file/dataset/collection viewed, file/dataset/collection author name/id, viewer name/id, file size)
  • extraction: Tracks Extractor Submissions (includes extractor name, target file/dataset, file/dataset author name/id, submitter name/id)
  • upload: Tracks File Uploads (includes uploader name/id, target dataset, upload size)

Review Time Estimate

  • Immediately
  • Within one week
  • When possible

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My change requires a change to the documentation.
  • I have updated the CHANGELOG.md.
  • I have signed the CLA
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@lmarini
Copy link
Member

lmarini commented Nov 18, 2020

Is this still in Draft or ready to be reviewed?

@lmarini lmarini closed this Nov 18, 2020
@lmarini lmarini reopened this Nov 18, 2020
@lmarini lmarini marked this pull request as ready for review November 20, 2020 15:03
@lmarini lmarini merged commit e29c72e into amplitude-clickstream Nov 20, 2020
@lmarini lmarini deleted the amplitude-clickstream-eventing branch November 20, 2020 15:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants