Pre commit autoformat #846
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
longshuicy
reviewed
Jan 8, 2024
| hooks: | ||
| - id: generate-frontend-api-client | ||
| name: generate-frontend-api-client | ||
| entry: bash -c 'cd frontend && npm run codegen:v2:file' |
There was a problem hiding this comment.
What's the trick that makes this command work without backend running?
There was a problem hiding this comment.
oh im answering myself...
Is it because the script extract-openapi = "python backend/extract-openapi.py app.main:app" can generate openapi.json without actually having a running background?
Does that mean I can also update the github action to eliminate all the steps of starting up all docker stacks?
longshuicy
approved these changes
Jan 8, 2024
| hooks: | ||
| - id: generate-frontend-api-client | ||
| name: generate-frontend-api-client | ||
| entry: bash -c 'cd frontend && npm run codegen:v2:file' |
There was a problem hiding this comment.
oh im answering myself...
Is it because the script extract-openapi = "python backend/extract-openapi.py app.main:app" can generate openapi.json without actually having a running background?
Does that mean I can also update the github action to eliminate all the steps of starting up all docker stacks?
longshuicy
pushed a commit
that referenced
this pull request
Mar 22, 2024
* Removed unused imports using autoflake. * Ordered imports using isort. * Reformatted using black. * Setting up pre-commits. * Ran pre-commit an all files. * Working on creating openapi.json without running backend to be used with codegen. * Fixed `MUI: The Tabs component doesn't accept a Fragment as a child.` * Fixed runtime error due to replacing `== None` with 'is None'. * Fixed runtime error due to replacing `== None` with 'is None'. * Automatically generate openapi json file using pre-commit hook. * Added codegen precommit hook. * Setting up prettier and eslint. * First run of prettier. * Runnin eslint and prettier as hooks. * Skip codegen directories when running eslint and prettier. * Flake8 E711 exception. Required for Beanie query to work. * Fixed search_users_prefix codegen stub. * Fixed beanie query for get_dataset_folders. * Ignore Flake8 E711 since beanie query do not support `is None`.
longshuicy
added a commit
that referenced
this pull request
Mar 22, 2024
* clear more breakpoints and move role to the Details * bump version up * add version to public layout too * update changelog * package json version * Pre commit autoformat (#846) * Removed unused imports using autoflake. * Ordered imports using isort. * Reformatted using black. * Setting up pre-commits. * Ran pre-commit an all files. * Working on creating openapi.json without running backend to be used with codegen. * Fixed `MUI: The Tabs component doesn't accept a Fragment as a child.` * Fixed runtime error due to replacing `== None` with 'is None'. * Fixed runtime error due to replacing `== None` with 'is None'. * Automatically generate openapi json file using pre-commit hook. * Added codegen precommit hook. * Setting up prettier and eslint. * First run of prettier. * Runnin eslint and prettier as hooks. * Skip codegen directories when running eslint and prettier. * Flake8 E711 exception. Required for Beanie query to work. * Fixed search_users_prefix codegen stub. * Fixed beanie query for get_dataset_folders. * Ignore Flake8 E711 since beanie query do not support `is None`. * bump keycloak chart version to 13 so it's using keycloak appversion 20 * update chart lock * add login to github repo * push set to true * revert login to github repo * version updates * revert * no v in the appVersion * change to make keycloak point to external url (#942) * 929 message on empty page if there is no datasets (#930) * basic message, need to improve * adding a login or register button * removing buttons * links to login or register if no public datasets * changing text * srink the version and align to left (#950) * moved key to grid instead of card * adding admin mode to the authwrapper (#951) * Fixed dataset parameters. They weren't being included in rabbtimq message. (#957) * fix extractor bugs and deployment script bug (#958) * Use --host 0.0.0.0 when running uvicorn to make backend listen on host IP. * fix missing add metadata button on dataset pycharm was complaining about missing publicView boolean in DisplayMetadata * Drag and Drop One or More Files (#935) * initial commit, add dependency, new class will eventually combine all file uploads * working on adding upload drag and drop * page does not load * drag and drop does not actually work * addign fileinputdrop as independent component * add fileupload drop inside uploadfiledraganddrop * drag and drop does not add files select selects files but misses the first one * drag and drop works now, is overwritten if file selected using button, need to fix * uploads but overwrites, need to fix * works for the select, need to fix other * should work for drop now too * was not an array * delete icon works removing console logs * drag and drop and select means other upload methods no longer needed * removing text in drag and drop * added to styles but not using because it does not work * some changes, not sure how to do rest * fix button * return to dataset * remove unnecessary imports --------- Co-authored-by: Chen Wang <cwang138@illinois.edu> * precommits --------- Co-authored-by: Luigi Marini <lmarini@illinois.edu> Co-authored-by: Todd Nicholson <40038535+tcnichol@users.noreply.github.com> Co-authored-by: toddn <tcnichol@illinois.edu>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces pre-commit hooks to run:
To setup install python library with
pipenv installand setup hooks withpre-commit install.NOTE: once in place, hooks are in the
.gitdirectory and will be run on any branch. They can be removed withpre-commit uninstallor by skipping them when git commit with--no-verify.Use
pre-commit run --all-filesto run them before committing.