Local backends fix #18
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…mpt tokens for proper model output culling
|
As a note: The issue occurs with the Llama2-chat tokenizer - it does not with the ~10 other tokenizers I've tested this with, hence the oversight. |
sherzod-hakimov
approved these changes
Nov 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix to properly cull prompt from model output.
The old code uses
tokenizer.apply_chat_template(messages, tokenize=Falseto get the prompt with chat formatting as string - but this method call does not return the actual decoded result, but one that is missing whitespaces, thus preventing string match for replacement. Decoding the actual tokenized prompt instead solves this issue.