Feature dialogue gamemaster reprompting, implements #41 #42
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… validation errors, fixed gameplay aborting on failed guesser validation
…hub.com/lpfennigschmidt/clembench-codenames into feature-dialogue-gamemaster-reprompting
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hope I understood your comment about changing the action type of the log message correctly, unfortunately I could not try out whether this works with my game as I currently get weird cuda errors again...
And I also found two typos, I hope they can simply be merged with this PR as well :)
Commit changes should be squashed into one commit, otherwise some of my codenames stuff will appear and disappear in the commit history unnecessarily