Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Funding Round contract: Add method for batch submission of messages #59

Closed
xuhcc opened this issue Jun 23, 2020 · 0 comments · Fixed by #69
Closed

Funding Round contract: Add method for batch submission of messages #59

xuhcc opened this issue Jun 23, 2020 · 0 comments · Fixed by #69
Assignees
Projects

Comments

@xuhcc
Copy link
Contributor

xuhcc commented Jun 23, 2020

To improve contributor's experience, we need a method for batch submission of messages. I think it should be implemented in FundingRound contract because the size of MACI contract is already approaching limits.

function submitMessageBatch(Message[] memory _messages, PubKey[] memory _encPubKeys)

It seems that we also need to ensure that the first message is a key-change command.

https://github.com/appliedzkp/maci/blob/master/specs/01_introduction.md#high-level-process

A later version of MACI will have to mitigate a vote-buying attack where a user may be bribed immediately when the voting period starts, such that their very first message is influenced by a briber. One solution to this is to have the contract to mandate that the first message that each participant sends is to change their key (see below).

@xuhcc xuhcc added this to MVP must-have: To do in MVP via automation Jun 23, 2020
@xuhcc xuhcc self-assigned this Jun 24, 2020
@xuhcc xuhcc moved this from MVP must-have: To do to In progress in MVP Jun 24, 2020
@xuhcc xuhcc mentioned this issue Jul 1, 2020
MVP automation moved this from In progress to Done Jul 16, 2020
daodesigner pushed a commit that referenced this issue Sep 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
MVP
  
Done
Development

Successfully merging a pull request may close this issue.

1 participant