Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Subtitle saving default file extension should follow current sub extension #2539

Closed
xLn2 opened this issue Feb 7, 2024 · 1 comment
Closed

Comments

@xLn2
Copy link

xLn2 commented Feb 7, 2024

Currently subtitle saving file extension defaultly choose subrip (srt) file extension.

My suggestion is:
If loaded subtitle has available saving extension (ass, ssa, srt, etc) for mpchc, choose it by default, and
If loaded subtitle isn't available for mpchc saving extension options but has custom styles, choose (recommended) style supported extension (like .ass/.ssa) by default, and
If none fit choose .srt by default

I tried to explain it simply, I hope it's not misunderstood or rude. Best regards.

@adipose
Copy link

adipose commented Feb 7, 2024

#2541

@clsid2 clsid2 closed this as completed Feb 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants