Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Media properties window anchoring and flashing issues #2819

Closed
xLn2 opened this issue May 31, 2024 · 10 comments
Closed

Media properties window anchoring and flashing issues #2819

xLn2 opened this issue May 31, 2024 · 10 comments

Comments

@xLn2
Copy link

xLn2 commented May 31, 2024

There is 3 main issues about Media Properties window

  • Unanchored objects

  • Flashing Tab Titles while window is moving

  • Moving a part of window to offscreen cause visual glitch that static text box borders appearing.

  1. Anchoring object needed for consistency (not sure correct terminology about Positions at anchoring but devs better understand situations)

resim
resim
resim

  1. Flashing tab titles

mpc-hc64_7vjDN0gPBy

  1. When part of window being on offscreen, it causes glitches (move the window to offscreen i.e right corner)
    It may be Mpc-hc global issue, also effect Subtitle downloader and Main Window.

resim
Moving window right bottom offscreen cause additional separator. But when sound icon show up it disappears.

resim

Subtitle downloader status bar has issue when part of window being at offscreen. That causes the progress bar and other elements to disappear in the status bar.

@adipose
Copy link

adipose commented Jun 4, 2024

#2823

  1. Resources tab supported
  2. Flicker fixed

Not following everything else, but see how this is.

@adipose
Copy link

adipose commented Jun 4, 2024

The off-screen thing is confirmed. Not sure what causes that but it appears to be related to theming, as it doesn't occur with native widgets.

The flicker continues on unthemed widgets. The problem seems to be restricted to the resizable dialogs, and is probably a bug in the erasebackground code. I fixed it by double-buffering, but in the native draw I need a better solution.

@xLn2
Copy link
Author

xLn2 commented Jun 4, 2024

Some pictures don't representing case so here is another one, probably these changes will break some strings translations.
Resized by left corner and top corner to left and top.
resim

@adipose
Copy link

adipose commented Jun 4, 2024

Wow. I did not even know it could be resized from the other corners. I don't think it was meant to be possible based on where they draw the resize grabber. Maybe a Windows change...

@adipose
Copy link

adipose commented Jun 4, 2024

OK that should be handled now.

@xLn2
Copy link
Author

xLn2 commented Jun 4, 2024

I'm not sure if it helps to diagnose the source of the problem, but here is something that might be relevant to # 3.
File > Save Image...
Change image format to BMP/PNG and again JPG
resim

Drag window's related part to offscreen and it will fix
resim

@adipose
Copy link

adipose commented Jun 4, 2024

I'm not sure if it helps to diagnose the source of the problem, but here is something that might be relevant to # 3. File > Save Image... Change image format to BMP/PNG and again JPG resim

Drag window's related part to offscreen and it will fix resim

The edit border glitch is fixed now. I'm not sure what you think this has to do with it, but when I toggle back and forth from PNG to JPEG, "Quality" comes back each time.

@xLn2
Copy link
Author

xLn2 commented Jun 4, 2024

MPC-HC (64-bit)

Build information:
Version: 2.2.1.55 (da42c4d)

Operating system:
Name: Windows 10 (Build 22H2)
Version: 10.0.19045 (64-bit)

Hardware:
CPU: Intel(R) Core(TM) i7-7700HQ CPU @ 2.80GHz
GPU: Intel(R) HD Graphics 630 (driver version: 31.0.101.2128)
Monitor: \.\DISPLAY1 - Generic PnP Monitor [1920x1080 32-bit 120 DPI] - [Current]

Text:
Scale Factor: 1.000000
Ansi Codepage: 1254


I just guess; moving objects from offscreen to current screen might trigger drawing behavior, at Subtitle downloader window's status bar some drawing is almost having done but seems like something is blocking it. These could be irrelevant issues.

mpc-hc64_YOqLdXbezM

firefox_Tv0OqIzFai

@adipose
Copy link

adipose commented Jun 4, 2024

You can enter a new issue for the save dialog. But I am unable to reproduce it.

@adipose
Copy link

adipose commented Jun 6, 2024

@clsid2 , I think all issues described here are fixed (except save dialog which has new issue now).

@clsid2 clsid2 closed this as completed Jun 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants