-
Notifications
You must be signed in to change notification settings - Fork 484
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MPC-HC doesn’t respect subtitle end times #38
Comments
Provide a sample file. |
Unfortunately all of the potential samples I have are hundreds of MB in size (ripped media) and uploading even one is not feasible on my connection. I trimmed one of the files (larger than 10 MB so had to use third-party host) and the trimmed clip still exhibits the same behaviour (first subtitle track, English), if this helps at all. I have exported subtitle tracks from some of the files, inspected them using Jubler, and their start/end timings seem proper. It doesn't do it with every file, though. Only some videos with subtitles have this issue. |
Are you really sure the extracted subtitle has a correct end time? I have logged the start/stop times of the first subtitle track, and the last entry has start time of approx 30sec and stop of 330sec. That value seems off by a factor 10. |
VLC player has the same problem. If there is a bug, it is likely to be in the FFmpeg code used by the splitter, not MPC-HC itself. I don't think this is something that I can fix. |
After doing some searching, it looks like you may be right. The original MKV that exists doesn't have this problem, but the remux to MP4 (for compatibility and metadata purposes) does. Sadly that bug was filed over 18 months ago. Guess this issue can be closed if nothing else needs to be added. |
With ripped media that contain soft subtitles, where the subtitle track is shorter than the length of the video track (e.g. foreign language parts), MPC-HC doesn’t respect the end times of the last subtitle. The last subtitle entry remains on the screen for the rest of the video.
The text was updated successfully, but these errors were encountered: