Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MPC-HC doesn’t respect subtitle end times #38

Closed
ItalianMammoth opened this issue Oct 14, 2018 · 6 comments
Closed

MPC-HC doesn’t respect subtitle end times #38

ItalianMammoth opened this issue Oct 14, 2018 · 6 comments

Comments

@ItalianMammoth
Copy link

With ripped media that contain soft subtitles, where the subtitle track is shorter than the length of the video track (e.g. foreign language parts), MPC-HC doesn’t respect the end times of the last subtitle. The last subtitle entry remains on the screen for the rest of the video.

@clsid2
Copy link
Owner

clsid2 commented Oct 15, 2018

Provide a sample file.

@ItalianMammoth
Copy link
Author

Unfortunately all of the potential samples I have are hundreds of MB in size (ripped media) and uploading even one is not feasible on my connection. I trimmed one of the files (larger than 10 MB so had to use third-party host) and the trimmed clip still exhibits the same behaviour (first subtitle track, English), if this helps at all.

I have exported subtitle tracks from some of the files, inspected them using Jubler, and their start/end timings seem proper. It doesn't do it with every file, though. Only some videos with subtitles have this issue.

@clsid2
Copy link
Owner

clsid2 commented Oct 19, 2018

Are you really sure the extracted subtitle has a correct end time? I have logged the start/stop times of the first subtitle track, and the last entry has start time of approx 30sec and stop of 330sec. That value seems off by a factor 10.

@ItalianMammoth
Copy link
Author

I wasn't sure whether the trimmed file would represent the issue, but here is the subtitle track in question exported from the full file.

screenshot 2018-10-20 at 03 54 29

@clsid2
Copy link
Owner

clsid2 commented Oct 20, 2018

VLC player has the same problem. If there is a bug, it is likely to be in the FFmpeg code used by the splitter, not MPC-HC itself.

I don't think this is something that I can fix.

@ItalianMammoth
Copy link
Author

After doing some searching, it looks like you may be right. The original MKV that exists doesn't have this problem, but the remux to MP4 (for compatibility and metadata purposes) does. Sadly that bug was filed over 18 months ago.

Guess this issue can be closed if nothing else needs to be added.

@clsid2 clsid2 closed this as completed Oct 24, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants