-
Notifications
You must be signed in to change notification settings - Fork 326
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Coptic stoplist? #634
Comments
I shall take this. |
Hi, |
Interesting find @AMR-KELEG . Are you interested in doing this one yourself? It should be pretty easy, plus you could learn about our upcoming release. Steps: |
Yes, I would love to do it myself. |
🤣 You're asking a fair question. I have found that it is best to code something and then ask for help. Presumably the people who made this first list are not totally ignorant. To make them better, in the future:
If @AMR-KELEG you're still interested, do you have a date by which you think you could finish this? Take as long as you want; but a soft deadline helps remember me follow up. If you have any issues w/ our new codebase (use the |
I am having problems with deadlines recently but I will make sure to work on this PR and provide frequent updates. |
Your plan here might work, but I think it is preferable to find a stopwords list from another and start here. For splitting words, this is a separate process that could/should be taken care of by the CopticStanzaProcess. @AMR-KELEG How about you raise an issue on their repo? https://github.com/cinkova/stopwoRds You can reference this issue here and ask for a plaintext version their Coptic stopwords. |
Let's hope we will get a response soon 😅 |
@AMR-KELEG Good work! Did the developer email you the list? |
Yes, she did 🎉 |
I added a few Coptic stopwords and your code is good. There's probably an issue w/ Stanza's Coptic module … will check it out. |
Coptic does not yet have a language-specific submodule in cltk.stop: https://github.com/cltk/cltk/tree/master/cltk/stop
The text was updated successfully, but these errors were encountered: