Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix broken NER doctest #903

Closed
kylepjohnson opened this issue Apr 26, 2019 · 4 comments
Closed

Fix broken NER doctest #903

kylepjohnson opened this issue Apr 26, 2019 · 4 comments

Comments

@kylepjohnson
Copy link
Member

Open to anyone.

This simple NER doctest:

cltk/cltk/tag/ner.py

Line 78 in 9b9cdb4

>>> tag_ner('latin', input_text='ut Venus, ut Sirius, ut Spica', output_type=list)

is all of a sudden failing (example: https://travis-ci.org/cltk/cltk/jobs/525125856#L1935 ).

The test expects 4 padded spaces on the left.

I have no idea why this would break all of a sudden.
@diyclassics diyclassics changed the title Fix broken NEW doctest Fix broken NER doctest Apr 30, 2019
@diyclassics
Copy link
Collaborator

Investigating... The doctest passes locally with python -m doctest -v ner.py.

@diyclassics
Copy link
Collaborator

This doctest can be considered redundant as there is a unittest that tests the same functionality—going to remove.

@diyclassics
Copy link
Collaborator

Separate (and for a different issue)—looks like this module could be updated/refactored/revisited in general. Will add to my to-do list...

kylepjohnson added a commit that referenced this issue May 2, 2019
@kylepjohnson
Small adjustment to formatting of doctest
e30b8ea 
Trying this as a quick fix to #903 . If this doesn't work, I recommend we comment it out, since we have this function covered elsewhere.
@kylepjohnson kylepjohnson mentioned this issue May 3, 2019
Merged
@kylepjohnson
Copy link
Member Author

Closing with #906

kylepjohnson pushed a commit that referenced this issue May 3, 2019
@diyclassics @kylepjohnson
Remove failing doctest; fixes #903 (#906)
cec0f43 
* Remove ner doctest

* Fix missing model import
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@kylepjohnson @diyclassics