Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stops update #600

Merged
merged 9 commits into from Nov 9, 2017
Merged

Stops update #600

merged 9 commits into from Nov 9, 2017

Conversation

diyclassics
Copy link
Collaborator

First round of code for a generalized (i.e. non-language-specific) Stop module. Code here for building a stoplist from a string, customizable through parameters such as length and preprocessing options. More to follow soon, both in terms of document-based stoplist building and language-specific add-ons. Also, a test for StringStoplist is included.

@diyclassics
Copy link
Collaborator Author

BTW I added the draft code for the document-based stoplist builder to stop.py—just left it commented out, since it is not working or tested yet.

@codecov-io
Copy link

codecov-io commented Oct 30, 2017

Codecov Report

Merging #600 into master will increase coverage by 0.03%.
The diff coverage is 92.3%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #600      +/-   ##
==========================================
+ Coverage   86.32%   86.36%   +0.03%     
==========================================
  Files         133      134       +1     
  Lines        8242     8294      +52     
==========================================
+ Hits         7115     7163      +48     
- Misses       1127     1131       +4
Impacted Files Coverage Δ
cltk/tests/test_stop.py 98.33% <100%> (+0.18%) ⬆️
cltk/stop/stop.py 91.3% <91.3%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a873c0a...6f36dcd. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants