This repository has been archived by the owner on Aug 28, 2020. It is now read-only.
Fixing side panel scrolling in reading view #63
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Suhaib Khan <suheb.work@gmail.com>
|
For the external library, until we upgrade to Meteor 1.3, can you move the external library to our core package and update the package.js here to include it on the client: https://github.com/cltk/cltk_frontend/blob/master/packages/core/package.js#L27 Otherwise, this looks good. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #42
I have used a external JS library for this. Currently it's present in
client/lib. Is that okay or there a better way to add external libs?Signed-off-by: Suhaib Khan suheb.work@gmail.com