Array pathing #8
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
|
@cludden fix looks good on our end, could we get a review/approval on this? |
|
one fix: can you revert the version bump? this is handled by standard-version when it generates CHANGELOG.md |
|
Will do now, thank you sir |
|
@cludden reverted version bump |
cludden
approved these changes
Mar 21, 2019
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This closes #7, as I've added breaking changes to
masterin my fork. Reverting those change.FYI - this fixes the issue raised in (and closes #6) for me. given the schema and context I provided in the bug report. Also, all tests pass, though I'm not sure how robust they are or aren't.