Update documentation to describe global composer installation. #16
Conversation
| exit(1); | ||
| } | ||
|
|
||
| require GRAPHCOMPOSER_INSTALL; |
There was a problem hiding this comment.
Unrelated change? Admittedly this never looked particularly appealing so I'm perfectly fine with changing this :) But I'd rather discuss this independent of your other changes.
There was a problem hiding this comment.
I copied this from phpunit as it seems to be a pretty sane way of handling this. I just used a constant for the benefits it provides if you need the value elsewhere.
|
Thanks for improving support for global installations through composer, very much appreciated 👍 I've just tested installing graph-composer globally without your changes applied. PR #12 already updated the autoloader paths, however we have yet to release a tagged version. Because of this, installing the latest tagged version ( With this (future) tag in place, your PR boils down to additional documentation - which, let me reemphasize, is appreciated at least just as much as code changes! As such, I'd much rather prefer to focus on that part here and perhaps discuss an update to the autoloader in a separate PR. |
|
Ah! I see. I failed to notice that in there. My eyes glossed right over that |
|
I can strip things down to the documentation and open a separate pull request for the more spread out code. |
nubs
changed the title
No worries, that code could certainly use some refactoring :)
Sure, go ahead if you feel it's still useful!
Thanks, the changes look to me 👍 I'll leave this open for feedback for a few days, but expect this to be part of the imminent v0.2.0 release. |
Okay, thanks for the info! |
|
Thanks for your effort and your patience @nubs! |
Update documentation to describe global composer installation.
|
Woo! No worries - thanks! |
No description provided.