Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support running phar archives with no ext-phar #8

Merged
merged 3 commits into from Aug 15, 2013
Merged

Support running phar archives with no ext-phar #8

merged 3 commits into from Aug 15, 2013

Conversation

clue
Copy link
Owner

@clue clue commented Aug 7, 2013

Always embed phar extractor into phar archive. This allows the phar file to be run even in environments without ext-phar.

This increases uncompressed file size by about 6 KiB, compressed file size by about 2 KiB. The below table shows some example file sizes with one of the smaller phar archives generated. Imo the increase in file size in negligible in contrast to how big most phar archives are.

Package Normal Size Size with Extractor Size delta Size delta%
clue/psocksd.phar 660,1 KiB 666,5 KiB +6,4 KiB +0,97%
clue/psocksd.phar.gz 144,0 KiB 146,0 KiB +2,0 KiB +1,39%
clue/psocksd.phar.bz2 110,5 KiB 112,2 KiB +1,7 KiB +1,54%

Fixes #6

@clue
Copy link
Owner Author

clue commented Aug 15, 2013

For now, we will not add an option to toggle this feature. It vastly improves portability for legacy setups and its increase in file size is negligible.

clue added a commit that referenced this pull request Aug 15, 2013
Support running phar archives with no ext-phar
@clue clue merged commit 4ef6a19 into master Aug 15, 2013
@clue clue deleted the add-extract branch August 15, 2013 23:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support for running on systems without Phar extension
1 participant