Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support PHP 8 #30

Merged
merged 1 commit into from
Dec 11, 2020
Merged

Support PHP 8 #30

merged 1 commit into from
Dec 11, 2020

Conversation

SimonFrings
Copy link
Collaborator

It's possible to run this code with PHP 8 馃帀

This pull request builds on top of #28 and #29.

$ docker run -it --rm -v `pwd`:/data --workdir=/data php:8.0 php vendor/bin/phpunit
PHPUnit 9.5.0 by Sebastian Bergmann and contributors.

..................................................                50 / 50 (100%)

Time: 00:00.365, Memory: 6.00 MB

OK (50 tests, 170 assertions)

@clue clue added this to the v1.2.0 milestone Dec 11, 2020
Copy link
Owner

@clue clue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@SimonFrings Thanks for the update, changes LGTM! :shipit:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants