Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run tests on PHP 8.3 and update test suite #33

Merged
merged 1 commit into from
Nov 9, 2023
Merged

Conversation

SimonFrings
Copy link
Collaborator

@SimonFrings SimonFrings commented Nov 9, 2023

This pull request builds on top of #19 and #28.

References: reactphp/socket#300, clue/reactphp-zenity#63 and others.

After this pull request is merged, we can continue with #32.

@SimonFrings SimonFrings changed the title Run tests on PHP 8.2 and PHP 8.3 and update test suite Run tests on PHP 8.3 and update test suite Nov 9, 2023
@SimonFrings SimonFrings added new feature New feature or request maintenance and removed maintenance labels Nov 9, 2023
@SimonFrings SimonFrings added this to the v1.3.0 milestone Nov 9, 2023
Copy link
Owner

@clue clue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@SimonFrings Thanks for the update, changes LGTM! :shipit:

@clue clue merged commit f3359d7 into clue:1.x Nov 9, 2023
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new feature New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants