Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove sentence classifier? #1030

Closed
BeckySharp opened this issue Jun 3, 2021 · 2 comments
Closed

remove sentence classifier? #1030

BeckySharp opened this issue Jun 3, 2021 · 2 comments
Assignees

Comments

@BeckySharp
Copy link
Contributor

Hey all -- this takes forever on a fresh build:

18:20:26.690 [scala-execution-context-global-173] INFO  o.c.wm.eidoscommon.utils.Sourcer$ - Sourcing resource file:/Users/bsharp/github/eidos/target/bg-jobs/sbt_98994499/job-1/target/918c5ffc/593838b3/eidos_2.12-1.2.1-
SNAPSHOT.jar!/org/clulab/wm/eidos/english/sentenceClassifier/sentence_classifier_idf_weight_1000_20000.txt

Do we really need this dep still? AFAIK it wasn't shown to be super useful? Or am I mistaken?

@kwalcock
Copy link
Member

kwalcock commented Jun 8, 2021

I timed the loading of the component and get less than 300ms. It looks like that component is one of the last to start loading and therefore prints its message very late. However, there is still lots being done, in overlapping threads, including the one listed next in the code, which is the processorsPrimer. That runs a sentence through processors so that its lazy values and companion objects get initialized and takes about 1000 times longer. I suspect that is what is taking up so much time and is perhaps being attributed to the other component. This shouldn't have anything to do with a fresh build, like after sbt clean. Maybe a fresh run?

@BeckySharp
Copy link
Contributor Author

BeckySharp commented Jun 8, 2021 via email

@kwalcock kwalcock closed this as completed Jun 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants