Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update collection compatibility library #732

Merged
merged 4 commits into from
Jul 13, 2023
Merged

Update collection compatibility library #732

merged 4 commits into from
Jul 13, 2023

Conversation

kwalcock
Copy link
Member

No description provided.

@kwalcock
Copy link
Member Author

The external scala-collection-compat library has been updated to take care of closing a Source, so neither the local Closer or Using are necessary. All that functionality is now in scala.util.Using.

fatdynet has also been updated similarly and is now at version 0.4.5, which is not yet used here. If there is to be a last version of processors with fatdynet, then I should update the dependency. It will remove the need for the implicit object CloseableModelSaverReleaser and prevent the eviction notice for scala-collection-compat mentioned in the build file.

MihaiSurdeanu
MihaiSurdeanu approved these changes Jul 13, 2023
View reviewed changes
Copy link
Contributor

@MihaiSurdeanu MihaiSurdeanu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @kwalcock

@kwalcock kwalcock merged commit 5324c05 into master Jul 13, 2023
1 check passed
@kwalcock kwalcock deleted the kwalcock/closeSource branch July 13, 2023 23:43
@kwalcock kwalcock mentioned this pull request Jul 19, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MihaiSurdeanu MihaiSurdeanu MihaiSurdeanu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@kwalcock @MihaiSurdeanu