Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Date rule issue776 #777

Merged
merged 5 commits into from
Feb 6, 2024
Merged

Date rule issue776 #777

merged 5 commits into from
Feb 6, 2024

Conversation

MihaiSurdeanu
Copy link
Contributor

No description provided.

@@ -5,12 +5,24 @@
# note: multi-word phrases must be tokenized in the same way as our tokenizer. If not sure, try the phrases in ./shell first!
#
first week // XXXX-XX-01 -- XXXX-XX-07
1st week // XXXX-XX-01 -- XXXX-XX-07
1st week // XXXX-XX-01 -- XXXX-XX-07
Copy link
Member

@kwalcock kwalcock Feb 5, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure this is what it (first week) really means, but that might have been discussed at length previously. If Saturday is the 1st of the month, then the first week might be 3-9 for me. Haven't I seen it written -W1? The first week of June is XXXX-06-W1.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will work on #778 and tidy a few things below and merge it all at once if that's OK.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Your comment about W1 is valid. I agree this would be the best representation.
Perhaps this could be done after merging these changes?

@kwalcock
Copy link
Member

kwalcock commented Feb 5, 2024

OK. Also, the Germans and Dutch number the weeks of the year, so 2023-W46, aside from the numbering within the month. There's a rule about what the first week is based on which weekday New Year's falls on. Maybe that's where I got it from. We probably never run into it in English text.

Oops. Google tracked this down: https://www.epochconverter.com/weeknumbers. Maybe it is a broader thing. If the Thursday rule/guideline holds within months, it could be used to produce exact dates when the year and month are known or a -W when not.

@kwalcock kwalcock merged commit 9c3ed9c into master Feb 6, 2024
1 check passed
@kwalcock kwalcock deleted the date-rule-issue776 branch February 6, 2024 02:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants