Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Get NumericEntityRecognizerShell to work again #781

Merged
merged 2 commits into from
Feb 6, 2024

Conversation

kwalcock
Copy link
Member

@kwalcock kwalcock commented Feb 6, 2024

No description provided.

@kwalcock
Copy link
Member Author

kwalcock commented Feb 6, 2024

This change was added to a branch off the branch used to produce v9.0.0-RC4. The change could be ported back to the balaur branch, which is dependent on snapshots and doesn't have all the other changes that were necessary for other versions of Scala or have updates that had been made to master. It is probably time to call the branch here masterV9 (or mainV9) and continue using it rather than balaur. Exercising it would be a good thing in case I have introduced bugs not yet discovered.

@MihaiSurdeanu
Copy link
Contributor

I agree. Thank you!

@kwalcock kwalcock merged commit d607498 into kwalcock/remergeBalaur Feb 6, 2024
1 check passed
@kwalcock kwalcock deleted the kwalcock/balaur_numeric_shell branch February 6, 2024 23:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants