Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature Request: Versions in instance list #565

Closed
n0t49a1n opened this issue Jan 21, 2024 · 3 comments · Fixed by #573
Closed

Feature Request: Versions in instance list #565

n0t49a1n opened this issue Jan 21, 2024 · 3 comments · Fixed by #573

Comments

@n0t49a1n
Copy link

to help with version control and being able to see the cluster as a whole
Would like to see the Version of the instance in the instance tab

below is a mock up of what i need
image

@n0t49a1n
Copy link
Author

id love to try this but i have no idea how this web works at all

@CCpersonguy
Copy link
Contributor

I'll make an attempt at this. The UI change seems straightforward, I'm reading code to figure out which events(s) should be used to send this info to the Controller.

@Cooldude2606
Copy link
Member

From a quick look, my approach would be expanding InstanceDetails to include the factorio version, then within InstanceInfo::toInstanceDetails you have access to the instance config where the game version is stored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants