Unable to restart instance after a patched in file is deleted

[Danielv123]

I updated factorio from 1.1.104 to 1.1.107 using the ingame updater. After updating, I get the following error both on the host and in the web interface developer tools when attempting to restart the running instance to apply the update:

[error] TypeError: Cannot read properties of null (reading 'async')
at /Users/danielv/project_files/clusterio/packages/host/dist/node/src/patch.js:98:100
at Array.map ()
at SaveModule.fromSave (/Users/danielv/project_files/clusterio/packages/host/dist/node/src/patch.js:98:61)
at /Users/danielv/project_files/clusterio/packages/host/dist/node/src/patch.js:182:135
at Array.map ()
at PatchInfo.fromSave (/Users/danielv/project_files/clusterio/packages/host/dist/node/src/patch.js:182:115)
at patch (/Users/danielv/project_files/clusterio/packages/host/dist/node/src/patch.js:330:37)
at async Instance.prepareSave (/Users/danielv/project_files/clusterio/packages/host/dist/node/src/Instance.js:661:9)
at async Instance.handleInstanceStartRequest (/Users/danielv/project_files/clusterio/packages/host/dist/node/src/Instance.js:823:24)

The issue remains after restarting the host and controller, however does not apply to newly created instances.

[Hornwitser]

In a patched save the clusterio.json file contains a list of all modules put into the save, and each modules have a "files" array with every file that was written into the save for that module. Error is thrown at

clusterio/packages/host/src/patch.ts

Line 81 in 79c1a2d

await Promise.all(json.files.map(async f => [f, await root.file(f)!.async("nodebuffer")] as const))

and indicates a file that was written into the save no longer exists. I guess Factorio didn't like the file and deleted it.

[Danielv123]

Well thats interesting. Let me investigate what file it deleted

[Danielv123]

Hm, looks like it got rid of the .gitignore in my module folder. Interesting. Guess I won't put it in there.

[Hornwitser]

The error condition of a file being missing should be handled gracefully instead of giving a cryptic error.

[Danielv123]

What would be the graceful way of handling this? Logging the missing file? Re-patching the save to include all the files?

[Hornwitser]

Log a warning that the file went missing. The current patch logic already replaces all patched in files with files from the modules to patch in.