New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add helm repo auth support #193
Conversation
Codecov Report
@@ Coverage Diff @@
## main #193 +/- ##
========================================
+ Coverage 7.96% 7.98% +0.02%
========================================
Files 29 29
Lines 3806 3834 +28
========================================
+ Hits 303 306 +3
- Misses 3479 3505 +26
+ Partials 24 23 -1
Continue to review full report at Codecov.
|
fce3e9b
to
98a92f7
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for working on this useful feature. Good job! Only a few knots here.
98a92f7
to
99b7e20
Compare
Signed-off-by: silenceper <silenceper@gmail.com>
99b7e20
to
b17925f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good job! 👍👍👍 Thanks @silenceper
What type of PR is this?
add helm repo auth support
What this PR does / why we need it:
Which issue(s) this PR fixes:
Fixes #186
Special notes for your reviewer: