Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add helm repo auth support #193

Merged
merged 1 commit into from Dec 8, 2021
Merged

Conversation

silenceper
Copy link
Member

What type of PR is this?

add helm repo auth support

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #186

Special notes for your reviewer:

@dixudx dixudx added the kind/feature New feature or request label Dec 3, 2021
@dixudx dixudx added this to the v0.7.0 milestone Dec 3, 2021
@codecov-commenter
Copy link

codecov-commenter commented Dec 3, 2021

Codecov Report

Merging #193 (b17925f) into main (0de5729) will increase coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##            main    #193      +/-   ##
========================================
+ Coverage   7.96%   7.98%   +0.02%     
========================================
  Files         29      29              
  Lines       3806    3834      +28     
========================================
+ Hits         303     306       +3     
- Misses      3479    3505      +26     
+ Partials      24      23       -1     
Impacted Files Coverage Δ
...ithub.com/clusternet/clusternet/pkg/utils/chart.go 0.00% <0.00%> (ø)
...ub.com/clusternet/clusternet/pkg/utils/deployer.go 0.00% <0.00%> (ø)
...ernet/clusternet/pkg/hub/apiserver/shadow/utils.go 100.00% <0.00%> (+10.71%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0de5729...b17925f. Read the comment docs.

Copy link
Member

@dixudx dixudx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for working on this useful feature. Good job! Only a few knots here.

pkg/apis/apps/v1alpha1/helm.go Outdated Show resolved Hide resolved
pkg/apis/apps/v1alpha1/helm.go Outdated Show resolved Hide resolved
pkg/hub/deployer/deployer.go Outdated Show resolved Hide resolved
pkg/utils/chart.go Outdated Show resolved Hide resolved
pkg/utils/deployer.go Outdated Show resolved Hide resolved
pkg/utils/chart.go Outdated Show resolved Hide resolved
Signed-off-by: silenceper <silenceper@gmail.com>
Copy link
Member

@dixudx dixudx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job! 👍👍👍 Thanks @silenceper

@dixudx dixudx merged commit 0fe3151 into clusternet:main Dec 8, 2021
@silenceper silenceper deleted the f-helm-auth branch December 8, 2021 09:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support add username, password to repo in HelmChart
3 participants