Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

populate Localizations for dividing scheduling #297

Merged
merged 1 commit into from Apr 11, 2022

Conversation

dixudx
Copy link
Member

@dixudx dixudx commented Apr 10, 2022

Signed-off-by: Di Xu stephenhsu90@gmail.com

What type of PR is this?

kind/feature

What this PR does / why we need it:

For dividing scheduling, overrides for replicas are needed per child cluster.
In this PR, Localizations are used to set overrides for replicas based on the replicaJsonPath from FeedInventory.

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

@dixudx dixudx added the kind/feature New feature or request label Apr 10, 2022
@dixudx dixudx added this to the v0.9.0 milestone Apr 10, 2022
@dixudx dixudx requested a review from Garrybest April 10, 2022 12:24
Signed-off-by: Di Xu <stephenhsu90@gmail.com>
@codecov-commenter
Copy link

Codecov Report

Merging #297 (6dc96ec) into main (4ad4105) will decrease coverage by 0.06%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main     #297      +/-   ##
==========================================
- Coverage   11.10%   11.04%   -0.07%     
==========================================
  Files          47       47              
  Lines        4970     4970              
==========================================
- Hits          552      549       -3     
- Misses       4380     4382       +2     
- Partials       38       39       +1     
Impacted Files Coverage Δ
...ernet/clusternet/pkg/hub/apiserver/shadow/utils.go 89.28% <0.00%> (-10.72%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4ad4105...6dc96ec. Read the comment docs.

@dixudx dixudx merged commit 0eb8654 into clusternet:main Apr 11, 2022
@dixudx dixudx deleted the populate-overrides branch April 11, 2022 07:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants