add endpoint slice handler #435
Conversation
Codecov Report
@@ Coverage Diff @@
## main #435 +/- ##
==========================================
+ Coverage 13.72% 13.74% +0.02%
==========================================
Files 61 61
Lines 6595 6607 +12
==========================================
+ Hits 905 908 +3
- Misses 5623 5629 +6
- Partials 67 70 +3
Continue to review full report at Codecov.
|
lmxia
force-pushed
the
feat/add-endpointslice-handler
branch
from
640d33c
to
81deb97
Compare
| LabelSelector: labels.SelectorFromSet(labels.Set{discoveryv1.LabelServiceName: utils.DerivedName(namespace, seName)}).String()}); err == nil { | ||
| shouldRetry := false | ||
| for _, item := range parentEndpointSliceList.Items { | ||
| if !localEndpointSliceMap[item.Name] { |
There was a problem hiding this comment.
This may not be right, since L144 uses namespaced name as keys.
There was a problem hiding this comment.
This may not be right, since L144 uses namespaced name as keys.
On L144, the enpointslice item is in child cluster, and the name is raw enpointslice name, like my-service-pt9nk.
While here, L149, the item is in parent cluster enpointslice, the name is default-my-service-pt9nk formated on L270.
There was a problem hiding this comment.
Ok, I got it.
This is a little bit tricky. Maybe we should add some comments here. Feel free to improve this in a new PR.
Signed-off-by: lmxia <xialingming@gmail.com>
lmxia
force-pushed
the
feat/add-endpointslice-handler
branch
from
81deb97
to
1cd55ee
Compare
Signed-off-by: lmxia xialingming@gmail.com
What type of PR is this?
kind/feature
What this PR does / why we need it:
Add endpoint slice event handler.
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Add remove endpoint slices logic, if endpoint slices exist in parent cluster but not in child cluster.