add service import controller #451
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dixudx
reviewed
Aug 11, 2022
| srcEndpointSliceMap[fmt.Sprintf("%s-%s", item.Namespace, item.Name)] = true | ||
| } | ||
|
|
||
| if targetEndpointSliceList, err := targetClient.DiscoveryV1().EndpointSlices(targetNamespace).List(context.TODO(), metav1.ListOptions{ |
There was a problem hiding this comment.
we can use endpointslice lister here.
Signed-off-by: lmxia <xialingming@gmail.com>
lmxia
force-pushed
the
feat/add-service-import-controller
branch
from
997499d
to
858a836
Compare
Codecov Report
@@ Coverage Diff @@
## main #451 +/- ##
==========================================
- Coverage 13.68% 13.61% -0.07%
==========================================
Files 61 62 +1
Lines 6613 6667 +54
==========================================
+ Hits 905 908 +3
- Misses 5637 5689 +52
+ Partials 71 70 -1
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: lmxia xialingming@gmail.com
What type of PR is this?
Feat add
What this PR does / why we need it:
Add serviceimport controller, running in parent cluster.
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer: