Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix error message in cluster status controller #657

Merged
merged 1 commit into from Apr 10, 2023

Conversation

dixudx
Copy link
Member

@dixudx dixudx commented Apr 7, 2023

What type of PR is this?

kind/bug

What this PR does / why we need it:

abnormal error message

W0407 09:35:37.351053       1 clusterstatus_controller.go:262] failed to list podMetris with err: 0x2462280
W0407 09:35:37.351744       1 clusterstatus_controller.go:286] failed to list nodeMetris with err: 0x2462280
W0407 09:35:57.339257       1 clusterstatus_controller.go:262] failed to list podMetris with err: 0x2462280
W0407 09:35:57.340165       1 clusterstatus_controller.go:286] failed to list nodeMetris with err: 0x2462280
W0407 09:36:17.325817       1 clusterstatus_controller.go:262] failed to list podMetris with err: 0x2462280
W0407 09:36:17.326530       1 clusterstatus_controller.go:286] failed to list nodeMetris with err: 0x2462280
W0407 09:36:37.335375       1 clusterstatus_controller.go:262] failed to list podMetris with err: 0x2462280
W0407 09:36:37.336139       1 clusterstatus_controller.go:286] failed to list nodeMetris with err: 0x2462280
W0407 09:36:57.325014       1 clusterstatus_controller.go:262] failed to list podMetris with err: 0x2462280

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Signed-off-by: Di Xu <stephenhsu90@gmail.com>
@dixudx dixudx added the kind/bug Something isn't working label Apr 7, 2023
@dixudx dixudx added this to the v0.16.0 milestone Apr 7, 2023
@dixudx dixudx requested a review from a team as a code owner April 7, 2023 10:53
@dixudx dixudx requested a review from yiwei-C April 7, 2023 10:53
@dixudx
Copy link
Member Author

dixudx commented Apr 7, 2023

cc @GeorgeGuo2018

@codecov-commenter
Copy link

Codecov Report

Merging #657 (94f973c) into main (e2ffa5f) will decrease coverage by 0.15%.
The diff coverage is n/a.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@            Coverage Diff             @@
##             main     #657      +/-   ##
==========================================
- Coverage   13.60%   13.45%   -0.15%     
==========================================
  Files          66       71       +5     
  Lines        7492     7693     +201     
==========================================
+ Hits         1019     1035      +16     
- Misses       6391     6574     +183     
- Partials       82       84       +2     

see 33 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@dixudx dixudx merged commit 9f150cc into clusternet:main Apr 10, 2023
7 checks passed
@dixudx dixudx deleted the fix-error-message branch April 10, 2023 01:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants