Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

install controller-manager for local running #658

Merged
merged 1 commit into from Apr 7, 2023

Conversation

dixudx
Copy link
Member

@dixudx dixudx commented Apr 7, 2023

What type of PR is this?

kind/enhancement

What this PR does / why we need it:

Which issue(s) this PR fixes:

xref #590

Special notes for your reviewer:

Signed-off-by: Di Xu <stephenhsu90@gmail.com>
@dixudx dixudx added this to the v0.16.0 milestone Apr 7, 2023
@dixudx dixudx requested a review from a team as a code owner April 7, 2023 10:57
@dixudx dixudx requested a review from DanielXLee April 7, 2023 10:57
@dixudx
Copy link
Member Author

dixudx commented Apr 7, 2023

cc @zxbyoyoyo

@codecov-commenter
Copy link

Codecov Report

Merging #658 (bea637a) into main (e2ffa5f) will decrease coverage by 0.19%.
The diff coverage is n/a.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@            Coverage Diff             @@
##             main     #658      +/-   ##
==========================================
- Coverage   13.60%   13.41%   -0.19%     
==========================================
  Files          66       71       +5     
  Lines        7492     7693     +201     
==========================================
+ Hits         1019     1032      +13     
- Misses       6391     6576     +185     
- Partials       82       85       +3     

see 34 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@dixudx dixudx merged commit 510961e into clusternet:main Apr 7, 2023
7 checks passed
@dixudx dixudx deleted the install-controller-manager-locally branch April 7, 2023 11:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants