Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

taint cluster with not-ready conditions #673

Merged
merged 1 commit into from Apr 28, 2023

Conversation

dixudx
Copy link
Member

@dixudx dixudx commented Apr 23, 2023

What type of PR is this?

kind/feature

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

@dixudx dixudx added the kind/feature New feature or request label Apr 23, 2023
@dixudx dixudx added this to the v0.16.0 milestone Apr 23, 2023
@dixudx dixudx requested review from a team as code owners April 23, 2023 07:28
@dixudx dixudx requested review from Garrybest and removed request for DanielXLee April 23, 2023 07:30
@codecov-commenter
Copy link

codecov-commenter commented Apr 23, 2023

Codecov Report

Merging #673 (de427ff) into main (e2ffa5f) will decrease coverage by 0.17%.
The diff coverage is n/a.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@            Coverage Diff             @@
##             main     #673      +/-   ##
==========================================
- Coverage   13.60%   13.43%   -0.17%     
==========================================
  Files          66       73       +7     
  Lines        7492     7876     +384     
==========================================
+ Hits         1019     1058      +39     
- Misses       6391     6733     +342     
- Partials       82       85       +3     

see 42 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@dixudx dixudx force-pushed the sched-plugin-cluster-unschedulable branch from ec63856 to de427ff Compare April 23, 2023 08:23
@dixudx dixudx force-pushed the sched-plugin-cluster-unschedulable branch from de427ff to ea19fc7 Compare April 26, 2023 11:34
@dixudx dixudx requested review from a team as code owners April 26, 2023 11:34
@dixudx dixudx requested a review from mars1024 April 26, 2023 11:34
@dixudx dixudx changed the title add scheduler plugin ClusterUnschedulable taint cluster with not-ready conditions Apr 27, 2023
@dixudx dixudx force-pushed the sched-plugin-cluster-unschedulable branch 5 times, most recently from 15ec511 to 19a3e14 Compare April 27, 2023 03:25
Copy link
Member

@Garrybest Garrybest left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice code!

@dixudx dixudx force-pushed the sched-plugin-cluster-unschedulable branch from 19a3e14 to 7ef13f1 Compare April 28, 2023 03:06
Signed-off-by: Di Xu <stephenhsu90@gmail.com>
@dixudx dixudx merged commit 48425cd into clusternet:main Apr 28, 2023
7 checks passed
@dixudx dixudx deleted the sched-plugin-cluster-unschedulable branch April 28, 2023 07:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants