Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mitigate manifest name with hyphens #83

Merged
merged 3 commits into from Nov 29, 2021

Conversation

dixudx
Copy link
Member

@dixudx dixudx commented Aug 26, 2021

What type of PR is this?

kind/bug

What this PR does / why we need it:

Manifest object name is formed by the namespaced name key. This will lead to resources declared in different namespaces map the same Manifest object.

For example,
A resource foo defined in below 2 namespaces,

  • resource name lovely-panda in namespace bar
  • resource name panda in namespace bar-lovely

will map a same Manifest object with name foos-bar-lovely-panda.

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

@dixudx dixudx added the kind/bug Something isn't working label Aug 26, 2021
@dixudx dixudx added this to the v0.5.0 milestone Sep 4, 2021
@dixudx dixudx modified the milestones: v0.5.0, v0.6.0 Oct 9, 2021
@dixudx dixudx modified the milestones: v0.6.0, v0.7.0 Nov 8, 2021
@dixudx dixudx marked this pull request as ready for review November 24, 2021 08:21
@dixudx dixudx force-pushed the fix-manifest-name branch 2 times, most recently from aef1072 to 8f49563 Compare November 26, 2021 04:08
Signed-off-by: Di Xu <stephenhsu90@gmail.com>
Signed-off-by: Di Xu <stephenhsu90@gmail.com>
Signed-off-by: Di Xu <stephenhsu90@gmail.com>
@codecov-commenter
Copy link

codecov-commenter commented Nov 29, 2021

Codecov Report

Merging #83 (066d966) into main (40fe10b) will increase coverage by 0.26%.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##            main     #83      +/-   ##
========================================
+ Coverage   7.77%   8.03%   +0.26%     
========================================
  Files         29      29              
  Lines       3780    3806      +26     
========================================
+ Hits         294     306      +12     
- Misses      3464    3477      +13     
- Partials      22      23       +1     
Impacted Files Coverage Δ
...et/clusternet/pkg/registry/shadow/template/rest.go 2.74% <0.00%> (+2.74%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 40fe10b...066d966. Read the comment docs.

@dixudx dixudx merged commit 0de5729 into clusternet:main Nov 29, 2021
@dixudx dixudx deleted the fix-manifest-name branch November 29, 2021 13:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants