Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support for the List object with remaining count and continue #33

Merged
merged 1 commit into from
Dec 23, 2021

Conversation

Iceber
Copy link
Member

@Iceber Iceber commented Dec 21, 2021

add search label search.clusterpedia.io/with-remaining-count and search.clusterpedia.io/with-continue

label url query
-selector "search.clusterpedia.io/with-remaining-count=true" withRemainingCount=true
--selector "search.clusterpedia.io/with-continue=true" withContinue=true

example:

curl http://127.0.0.1:8080/api/v1/namespaces/default/pods?labelSelector=search.clusterpedia.io/with-remaining-count=true&limit=1&withContinue=true
{
    "kind": "PodList",
    "apiVersion": "v1",
    "metadata": {
        "continue": "1",
        "remainingItemCount": 1
    },
    "items": [
    ....
    ]
}

@Iceber Iceber force-pushed the list-attach branch 4 times, most recently from fb07368 to a0b88d4 Compare December 21, 2021 10:04
@Iceber Iceber force-pushed the list-attach branch 2 times, most recently from a0659fc to 01b5481 Compare December 22, 2021 05:39
@Iceber
Copy link
Member Author

Iceber commented Dec 22, 2021

Does not support List as ParitalObjectMetadataList with count, other cases will come with count.
kubernetes/kubernetes#107177

@wzshiming
Copy link
Member

LGTM

@Iceber
Copy link
Member Author

Iceber commented Dec 22, 2021

After a simple discussion, it was decided to use WithRemaningCount and WithContinue.
with is more commonly used than attach

@Iceber Iceber changed the title attach the remaining count and continue to the List object support for the List object with remaining count and continue Dec 23, 2021
@Iceber Iceber merged commit c31607f into clusterpedia-io:main Dec 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants