-
Notifications
You must be signed in to change notification settings - Fork 122
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
support for using go plugin
to register storage layer plugins
#436
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hi @Iceber, DetailsInstructions for interacting with me using comments are available here. |
Signed-off-by: Iceber Gu <wei.cai-nat@daocloud.io>
Signed-off-by: Iceber Gu <wei.cai-nat@daocloud.io>
b2c57b7
to
f9d2973
Compare
Iceber
commented
Nov 1, 2022
cc3efb4
to
e9d888a
Compare
/label do-not-merge/hold |
b74d81b
to
f377316
Compare
go plugin
to register storage layer plugins
f377316
to
3b50b4d
Compare
52cb90c
to
faa1172
Compare
5daf3ad
to
4a11079
Compare
72d5c20
to
be909dd
Compare
be909dd
to
1617437
Compare
Signed-off-by: Iceber Gu <wei.cai-nat@daocloud.io>
1617437
to
25131d6
Compare
5 tasks
Signed-off-by: Iceber Gu <wei.cai-nat@daocloud.io>
/assign |
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind feature
What this PR does / why we need it:
LoadPlugins
function to load storage layer pluginsstorage.LoadPlugins
go plugin
Build flow with go plugin support
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?: