Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#546 add kube state metrics namespace command #566

Merged
merged 1 commit into from
Aug 22, 2023

Conversation

scydas
Copy link
Contributor

@scydas scydas commented Aug 21, 2023

Signed-off-by: scydas scyda@outlook.com

What type of PR is this?
/kind feature

What this PR does / why we need it:

Which issue(s) this PR fixes:
Fixes #546

Special notes for your reviewer:

Does this PR introduce a user-facing change?:
release-note
kube-state-metrics-namespaces: Comma-separated list of namespaces to be enabled
kube-state-metrics-namespaces-denylist Comma-separated list of namespaces not to be enabled. If namespaces and namespaces-denylist are both set, only namespaces that are excluded in namespaces-denylist will be used

@clusterpedia-bot
Copy link

Hi @scydas,
Thanks for your pull request!
If the PR is ready, use the /auto-cc command to assign Reviewer to Review.
We will review it shortly.

Details

Instructions for interacting with me using comments are available here.
If you have questions or suggestions related to my behavior, please file an issue against the gh-ci-bot repository.

@clusterpedia-bot clusterpedia-bot added the kind/feature New feature label Aug 21, 2023
@scydas scydas force-pushed the kube-state-metrics-namespaces branch 2 times, most recently from 266da8e to 9e2d4b5 Compare August 21, 2023 09:30
pkg/kube_state_metrics/metrics_store.go Outdated Show resolved Hide resolved
pkg/kube_state_metrics/metrics_store.go Outdated Show resolved Hide resolved
pkg/kube_state_metrics/metrics_store.go Outdated Show resolved Hide resolved
pkg/kube_state_metrics/metrics_store.go Outdated Show resolved Hide resolved
@scydas scydas force-pushed the kube-state-metrics-namespaces branch from 9e2d4b5 to f574cec Compare August 21, 2023 10:09
Signed-off-by: scydas <scyda@outlook.com>
@scydas scydas force-pushed the kube-state-metrics-namespaces branch from f574cec to 8f2e6aa Compare August 22, 2023 02:11
Copy link
Member

@Iceber Iceber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, Thanks for your contribution

@Iceber Iceber merged commit f79e913 into clusterpedia-io:main Aug 22, 2023
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support for filtering exposed resource state metrics based on namespace
3 participants