Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Zstd compressor dummy #2

Merged
merged 25 commits into from
Dec 21, 2023
Merged

Zstd compressor dummy #2

merged 25 commits into from
Dec 21, 2023

Conversation

clusty
Copy link
Owner

@clusty clusty commented Dec 19, 2023

No description provided.

Copy link
Collaborator

@pleprince pleprince left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly formatting issues (always use the project's .clang-format).
One bug and an open question about adding BLOSC as a dependency.
If you can do this asap, I will make a second pass. ;-)

src/examples/deepExamples.cpp Show resolved Hide resolved
@@ -220,3 +222,7 @@ openexr_define_library(OpenEXR
OpenEXR::IlmThread
OpenEXR::OpenEXRCore
)

target_include_directories(OpenEXR PUBLIC "/home/vladal/bin/include/")
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How do we fix this ? I will check how deps are generally handled here.

src/lib/OpenEXR/ImfCompressionAttribute.cpp Outdated Show resolved Hide resolved
src/lib/OpenEXR/ImfCompressor.cpp Outdated Show resolved Hide resolved
src/lib/OpenEXR/ImfCompressor.cpp Outdated Show resolved Hide resolved
src/lib/OpenEXR/ImfZstdCompressor.cpp Outdated Show resolved Hide resolved
src/lib/OpenEXR/ImfZstdCompressor.cpp Outdated Show resolved Hide resolved
src/lib/OpenEXR/ImfZstdCompressor.h Show resolved Hide resolved
src/lib/OpenEXRCore/base.c Outdated Show resolved Hide resolved
src/lib/OpenEXRCore/base.c Show resolved Hide resolved
clusty and others added 4 commits December 20, 2023 09:21
Co-authored-by: Philippe Leprince <github.pleprince@gmail.com>
Signed-off-by: Vlad Lazar <vladal@unity3d.com>
Copy link
Collaborator

@pleprince pleprince left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks Vlad !

src/lib/OpenEXR/ImfZstdCompressor.cpp Outdated Show resolved Hide resolved
src/lib/OpenEXR/ImfZstdCompressor.cpp Outdated Show resolved Hide resolved
src/lib/OpenEXR/ImfZstdCompressor.cpp Outdated Show resolved Hide resolved
src/lib/OpenEXR/ImfZstdCompressor.cpp Outdated Show resolved Hide resolved
clusty and others added 4 commits December 20, 2023 11:29
Co-authored-by: Philippe Leprince <github.pleprince@gmail.com>
Signed-off-by: Vlad Lazar <vladal@unity3d.com>
@clusty clusty marked this pull request as ready for review December 21, 2023 13:37
@clusty clusty merged commit 192e15f into main Dec 21, 2023
pleprince added a commit that referenced this pull request Apr 23, 2024
Signed-off-by: Philippe Leprince <github.pleprince@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants