more lint

Signed-off-by: clux <sszynrae@gmail.com>

.github/workflows/lint.yml

@@ -19,5 +19,3 @@ jobs:
     - run: env | grep SHELLCHECK
     - run: just lint
     - uses: ansible/ansible-lint-action@v6
-      with:
-        path: 'site.yml bootstrap.yml'

.yamllint

@@ -20,5 +20,5 @@ rules:
   trailing-spaces: enable
   indentation: # lists start with hyphen on the same indentation level as parent
     spaces: 2
-    indent-sequences: no
-    check-multi-line-strings: no
+    indent-sequences: false
+    check-multi-line-strings: false

justfile

@@ -50,5 +50,5 @@ lint:
 
 # run full lint plus bats test
 test: lint
-  ansible-lint site.yml bootstrap.yml
+  ansible-lint site.yml bootstrap.yml secrets.yml
   bats test

roles/xdg/handlers/main.yml

@@ -2,3 +2,4 @@
 
 - name: xdg-mime sshtorrent
   command: xdg-mime default sshtorrent.desktop x-scheme-handler/magnet
+  changed_when: true # TODO: fixme

roles/xdg/tasks/torrent.yml

@@ -1,20 +1,23 @@
 ---
 # xdg
 
-- template: src=templates/sshtorrent.desktop dest=/usr/share/applications/
+- template:
+    src: templates/sshtorrent.desktop
+    dest: /usr/share/applications/
+    mode: 0644
   become: true
   notify: xdg-mime sshtorrent
 
 - template:
-    src=templates/magnet
-    dest=/home/{{ user }}/.local/bin/magnet
-    owner={{ user }}
-    mode="u+rwx"
+    src: templates/magnet
+    dest: /home/{{ user }}/.local/bin/magnet
+    owner: '{{ user }}'
+    mode: "u+rwx"
   when: inventory_hostname != "broxy"
 
 - template:
-    src=templates/magnet.local
-    dest=/home/{{ user }}/.local/bin/magnet
-    owner={{ user }}
-    mode="u+rwx"
+    src: templates/magnet.local
+    dest: /home/{{ user }}/.local/bin/magnet
+    owner: '{{ user }}'
+    mode: "u+rwx"
   when: inventory_hostname == "broxy"

secrets.yml

@@ -1,19 +1,24 @@
 ---
-- connection: local
+- name: provision secrets from gogs post bootstrap
+  connection: local
   hosts: all
   vars_files:
   - vars/gogs.yml
   user: "{{ user }}"
   tasks:
-  - template: src=templates/ssh_config.j2 dest=/home/{{ user }}/.ssh/config
+  - name: provision an initial ssh config
+    template:
+      src: templates/ssh_config.j2
+      dest: /home/{{ user }}/.ssh/config
+      mode: 0755
 
   - name: Checkout secret modules
     git:
-      repo=git@{{ gogs_name }}:{{ gogs_user }}/{{ item }}.git
-      dest=/home/{{ user }}/{{ item }}
-      key_file=/home/{{ user }}/.ssh/{{ gogs_ssh_id }}
-      accept_hostkey=yes
-      update=no
+      repo: 'git@{{ gogs_name }}:{{ gogs_user }}/{{ item }}.git'
+      dest: /home/{{ user }}/{{ item }}
+      key_file: /home/{{ user }}/.ssh/{{ gogs_ssh_id }}
+      accept_hostkey: true
+      update: false # noqa: latest
     with_items:
     - ssh
     - gpg