Skip to content

Commit

Permalink
some of these lints feel pointlessly bloaty...
Browse files Browse the repository at this point in the history
going to stop doing fqcn on action-core

Signed-off-by: clux <sszynrae@gmail.com>
  • Loading branch information
clux committed Jun 27, 2023
1 parent dd0f08d commit 338e916
Show file tree
Hide file tree
Showing 7 changed files with 13 additions and 15 deletions.
1 change: 0 additions & 1 deletion .ansible-lint
Original file line number Diff line number Diff line change
@@ -1,5 +1,4 @@
skip_list:
- 'var-naming[no-role-prefix]'
- 'fqcn[action-core]'
- 'name[casing]'
- 'name[missing]'
17 changes: 8 additions & 9 deletions roles/arch/tasks/pacman.yml
Original file line number Diff line number Diff line change
@@ -1,21 +1,20 @@
---
# pacman config

- name: pacman parallel downloads
- name: pacman configuration
lineinfile:
path: /etc/pacman.conf
regexp: '^#ParalllelDownloads ='
line: "{{ item.line }}"
regexp: "{{ item.regexp }}"
with_items:
- regexp: '^#ParalllelDownloads ='
line: 'ParallelDownloads = 5'

- name: pacman colors
lineinfile:
path: /etc/pacman.conf
regexp: '#Color'
- regexp: '#Color'
line: 'Color'

- name: pacman enable multilib for steam
- name: pacman multilib
lineinfile:
path: /etc/pacman.conf
backrefs: true
regexp: '^\#\[multilib\]'
line: '[multilib]\nInclude = /etc/pacman.d/mirrorlist'
backrefs: true
2 changes: 1 addition & 1 deletion roles/lpms/tasks/cargo.yml
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@
changed_when:
- "'downloading' in stable_output.stderr"

- set_fact:
- ansible.builtin.set_fact:
cargo_state: "{{ 'latest' if (upgrade_tasks | default(false)) else 'present' }}"

Check failure on line 12 in roles/lpms/tasks/cargo.yml

View workflow job for this annotation

GitHub Actions / lint

var-naming[no-role-prefix]

Variables names from within roles should use role_name_ as a prefix. (set_fact: cargo_state)

- name: install cargo modules
Expand Down
2 changes: 1 addition & 1 deletion roles/lpms/tasks/npm.yml
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@
regexp: '^prefix='
line: 'prefix=/home/{{ user }}/.node_modules'

- set_fact:
- ansible.builtin.set_fact:
npm_state: "{{ 'latest' if (upgrade_tasks | default(false)) else 'present' }}"

Check failure on line 14 in roles/lpms/tasks/npm.yml

View workflow job for this annotation

GitHub Actions / lint

var-naming[no-role-prefix]

Variables names from within roles should use role_name_ as a prefix. (set_fact: npm_state)

- name: Install global npm dependencies
Expand Down
2 changes: 1 addition & 1 deletion roles/lpms/tasks/pip.yml
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@
# it is generally recommended not to do this, and don't care that much about this.
# If we find out that we need a more up-to-date yt-dlp then we can always override later.

- set_fact:
- ansible.builtin.set_fact:
pip_state: "{{ 'latest' if (upgrade_tasks | default(false)) else 'present' }}"

Check failure on line 15 in roles/lpms/tasks/pip.yml

View workflow job for this annotation

GitHub Actions / lint

var-naming[no-role-prefix]

Variables names from within roles should use role_name_ as a prefix. (set_fact: pip_state)

# Some of these technically do exist as well in pacman, but want some updates faster
Expand Down
2 changes: 1 addition & 1 deletion roles/ssh/handlers/main.yml
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,6 @@

- name: restart sshd
become: true
service:
ansible.builtin.service:
name: sshd
state: restarted
2 changes: 1 addition & 1 deletion roles/ssh/tasks/sshd.yml
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@
notify:
- restart sshd

- service:
- ansible.builtin.service:
name: sshd
state: started
enabled: true

0 comments on commit 338e916

Please sign in to comment.