Fix csv marshaller for marshal chan #15
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The test for writeToChan exemplifies the problem. Marshallers are silently getting turned into blank strings.
The call to .Interface() requires an addressable value. However, the values that come out of a channel are not necessarily addressable if they are non-pointer values. A value is non-addressable if it doesn't have a stable address (i.e. there is a guarantee that there will be something meaningful at the address). This can be interpreted as "an addressable value is heap allocated". So, our non-addressable value is stack allocated. We can turn it into an addressable value, but copying it to the heap, which is what this code does.
quintenpalmer
approved these changes
Jul 10, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The commit message for dbd300f lays out the bulk of the issue, so I won't repeat it here. The context is that I was trying to use MarshalChan in gillnet only to discover that it didn't work as advertised with respect to
broadcast.Dates. So, I fixed it.Please let me know your thoughts on this solution.