Fix for crash on missing PTS/DTS information on keyframes in ts-inspe…

…ctor Fixes issue: videojs#250
cmacq2 · Mar 13, 2019 · 9654c23 · 9654c23
1 parent 511d4da
commit 9654c23
Showing 1 changed file with 9 additions and 2 deletions.
diff --git a/lib/tools/ts-inspector.js b/lib/tools/ts-inspector.js
@@ -220,8 +220,15 @@ var parseVideoPes_ = function(bytes, pmt, result) {
                     i += pes.byteLength;
                   }
                   if (probe.ts.videoPacketContainsKeyFrame(frame)) {
-                    result.firstKeyFrame = probe.ts.parsePesTime(frame);
-                    result.firstKeyFrame.type = 'video';
+                    var firstKeyFrame = probe.ts.parsePesTime(frame);
+
+                    // PTS/DTS may not be available. Simply *not* setting
+                    // the keyframe seems to work fine with HLS playback
+                    // and definitely preferable to a crash with TypeError...
+                    if (firstKeyFrame) {
+                      result.firstKeyFrame = firstKeyFrame;
+                      result.firstKeyFrame.type = 'video';
+                    }
                   }
                   currentFrame.size = 0;
                 }